Ways to improve foll. Java code -

any ways improve foll. code block :

public class myunits {     public static string millseconds = "milliseconds";     public static string seconds = "seconds";     public static string minutes = "minutes";     public static string hours = "hours";      public int quantity;     public string units;      public myunits(int quantity, string units) {         this.quantity = quantity;         this.units = units;     }      public string tostring() {         return (quantity + " " + units);     }      // test code     public static void main(string[] args) {         system.out.println(new myunits(1, myunits.millseconds));         system.out.println(new myunits(2, myunits.seconds));         system.out.println(new myunits(3, myunits.minutes));         system.out.println(new myunits(4, myunits.hours));     } } 

any appreciated.

the static ints should final. usual modifier "constant" in java is

public static final <type> <name> = <value>; 

a bigger enhancement: exchange static int enum:

public enum unit {millisecond, second, minute, hour} 

the new constructor signature be:

public myunits(int quantity, unit unit) { ... } 

the non-static fields in myunit should made private. add getter/setter methods access.

and (and serious code only), i'd separate test code class. have @ testing frameworks, junit , implement separate test classes.